feat: optimize ci cd workflow #6744
Conversation
…ive workflow tables.
…ow runner tables and remove redundant `status` parameters. Integrate CI status optimization fallback in `CiHandlerImpl`.
…iHandlerImpl`. Streamline CI status fetching through existing repository methods.
…e` package, integrate optimized CI status fetching and fallback logic in `CiHandlerImpl`.
…ndLastTriggeredWorkflowByCiIdsOptimized`. Add fallback to legacy method for error handling. Update repository with the optimized query method.
prkhrkat
requested review from
prakarsh-dt,
vikramdevtron,
nishant-d and
vivek-devtron
as code owners
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
Changelist by BitoThis pull request implements the following key changes.
|
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #9e94a6
Actionable Suggestions - 1
-
internal/sql/repository/pipelineConfig/CiWorkflowRepository.go - 1
- Incorrect error handling in fallback logic · Line 305-305
Review Details
-
Files reviewed - 10 · Commit Range:
87521d5..cb6ce49- internal/sql/repository/pipelineConfig/CiWorkflowRepository.go
- internal/sql/repository/pipelineConfig/WorkflowStatusLatestRepository.go
- pkg/pipeline/CiHandler.go
- pkg/workflow/status/workflowStatusLatest/WorkflowStatusLatestService.go
- pkg/workflow/status/workflowStatusLatest/WorkflowStatusUpdateService.go
- pkg/workflow/status/workflowStatusLatest/wire_workflow_status_latest.go
- pkg/workflow/wire_workflow.go
- scripts/sql/34203900_workflow_status_latest_tables.down.sql
- scripts/sql/34203900_workflow_status_latest_tables.up.sql
- wire_gen.go
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at shivam@devtron.ai.
Documentation & Help
AI Code Review powered by
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
…services to handle it. Integrate `BlobStorageEnabled` from the data model and replace default hardcoded value in `WorkflowStatusUpdateServiceImpl`.
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
Code Review Agent Run #bf339dActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
… `ci_workflow_status_latest` table with fallback to legacy query methods. Update repositories with new helper methods to support this approach.
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
Code Review Agent Run #291051Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
…sLatestRepository` and update references in `CiHandlerImpl` for clarity.
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
…r clarity, introducing `GetCiWorkflowStatusFromCiWorkflow` in `adapter`, and improving log consistency.
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
…improved clarity and consistency. Update logging and fallback logic in CI status and workflow fetching.
…timize-ci-cd-workflow
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
…ntegration with `WorkflowStatusLatestService`. Update `CiHandlerImpl` references and clean up unused code.
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
…line CI/CD workflow status handling.
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
Code Review Agent Run #d1fe17Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
…ow_id` and `workflow_runner_id`
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
… for CI/CD workflow statuses, refactor repository methods, and modify unique constraints in workflow status tables.
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
Code Review Agent Run #8f078aActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
|
iamayushm
changed the title
iamayushm
changed the title
|
/resolve |
Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2435
Checklist:
Does this PR introduce a user-facing change?
Summary by Bito
This PR optimizes the CI/CD workflow by improving workflow status management, enhancing cluster management, and refining error handling. It standardizes unique constraints in SQL tables, refactors repository interfaces and service layers, and introduces new methods for retrieving clusters. The changes ensure consistent use of 'pipeline_id', enhance transaction support and error logging, and improve overall performance and maintainability.