Adjust ingress expiry to not be more than 5 min after the consent message #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Llorenç <llorenc.muntaner@dfinity.org>
# Motivation Expiry takes as a constructor argument the time _delta_ in millis. Supplied was the absolute timestamp as a number (but too large to use accurate integer representation). This fixes the bug. In addition, the test vector should be called ICRC-21 rather then ICRC-29. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Llorenç <llorenc.muntaner@dfinity.org>
…sage The previous value was too far into the future, such that the consent message would be considered stale.
size-limit report 📦
|
|
@frederikrothenberger u still need this? |
lmuntaner
force-pushed
the
test-vectors
branch
from
a1c1eb7 to
463b755
Compare
lmuntaner
force-pushed
the
test-vectors
branch
from
463b755 to
12a3d63
Compare
lmuntaner
force-pushed
the
test-vectors
branch
from
12a3d63 to
b937e2e
Compare
lmuntaner
force-pushed
the
test-vectors
branch
from
f169fac to
2ade7e7
Compare
lmuntaner
force-pushed
the
test-vectors
branch
from
2ade7e7 to
81ebca9
Compare
lmuntaner
force-pushed
the
test-vectors
branch
2 times, most recently
from
0693ee5 to
7b38b33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous value was too far into the future, such that the consent message would be considered stale.