Support xarray.DataTree through arviz.preview
#306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arviz is migrating to xarray.DataTree instead of InferenceData soon. Ref: https://python.arviz.org/en/stable/user_guide/migration_guide.html.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arviz is migrating to
xarray.DataTreeobjects to replaceInferenceDatasoon (see the Migration Guide docs page).The only thing required for corner to work with a
DataTreeobject seems to be importingconvert_to_datasetfromarviz.preview. This PR tries to do that and falls back to importing it fromarviz. There is also a unit test usingarivz.previewto convert a dictionary to aDataTree.After Arviz 1.0 is released, the new interface currently in
arviz.previewwill replace the currentarviznamespace. Some extra changes to corner will likely be required then, but for now this PR allows users to experiment with the new interface while keeping everything working with the current ("legacy") arviz version.