feat: MinT provider support #449
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey! Sorry for the delay and we really appreciate the attempt. As me and @rafaelmardojai were discussing this, we realized that Dialect isn't quite ready for MinT yet. The code itself was fine except for a misunderstanding in how The core of the issue is that Dialect currently has no support for mapping each src language to a different set of dest languages. Basically, what you tried to do with We will revisit MinT once we have a better way of doing that. But we found a bug thanks to you! (#450) Thanks for your effort 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #409
Hello! First time contributing here. Tried to do it as clean as possible and, in keeping with the discussion in the issue, I've used translate.wmcloud.org as the default instance.