Initial update for TypedBindingId support #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It defines a new abstract class - TypedBindingId that caries a types of the binding. In this case when a programmer will try to use wrong ID in the module definition the compiler generates an error. As an example, the BindingIdObjectsTest.scala is not compiled because it uses a wrong binding. The injection is not implemented. If it is interesting I could finish the job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really like subcut. Great Job. I have a small enhancement how to make subcut type safer. When we use BindingId for defining/injecting primitives or special objects then we could make mistakes and use wrong id object. In this case compiler will not catch the mistake and we will learn it during runtime. The below approach allow us to catch some errors during compilation stage.
It defines a new abstract class - TypedBindingId that caries a types of the binding. In this case
when a programmer will try to use wrong ID in the module definition the compiler generates an error.
As an example, the BindingIdObjectsTest.scala is not compiled because it uses a wrong binding.
The injection is not implemented. If it is interesting I could finish the job.