-
Notifications
You must be signed in to change notification settings - Fork 16
add Bitcoin Connect #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alan-AC7
wants to merge
7
commits into
digi-monkey:master
Choose a base branch
from
Alan-AC7:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add Bitcoin Connect #343
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8b30faf
added btc component on profile preferences
Alan-AC7 4147141
corrections were made on package.json, bitcoinconnect and preferences…
Alan-AC7 c5e5284
package.json, btcbutton, preference were changed
Alan-AC7 d9c9251
imported bitcoin connect on client side in src/components/PostItems/P…
Alan-AC7 7a704fc
used dynamic import while importing btc-connect
Alan-AC7 1c6baf8
corrected an unnecesary prop on btc-connect component
Alan-AC7 2d6e093
added key=btc-connect on Bitcoin Connect Component
Alan-AC7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import React from 'react'; | ||
| import { Button } from '@getalby/bitcoin-connect-react'; | ||
|
|
||
| interface BitcoinButtonProps {} | ||
|
|
||
| const BitcoinButton: React.FC<BitcoinButtonProps> = () => { | ||
| const handleConnect = () => { | ||
|
|
||
| }; | ||
|
|
||
| return ( | ||
| <div className="bitcoin-connect-container"> | ||
| <Button onConnect={handleConnect} /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default BitcoinButton; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,3 +11,4 @@ | |
| .about { | ||
| text-align: center; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -17,6 +17,9 @@ import { RelayGroup } from 'core/relay/group'; | |||||
| import { useReadonlyMyPublicKey } from 'hooks/useMyPublicKey'; | ||||||
| import { useEffect, useState } from 'react'; | ||||||
| import { exportDB } from 'dexie-export-import'; | ||||||
| import BitcoinButton from 'components/BitcoinConnect/BitcoinButton'; | ||||||
|
|
||||||
|
|
||||||
|
|
||||||
| export default function Preference() { | ||||||
| const myPublicKey = useReadonlyMyPublicKey(); | ||||||
|
|
@@ -98,7 +101,7 @@ export default function Preference() { | |||||
| duration: 0, | ||||||
| }); | ||||||
|
|
||||||
| // Function to close the loading message when called | ||||||
|
|
||||||
| const closeLoadingMessage = () => { | ||||||
| message.destroy(key); | ||||||
| }; | ||||||
|
|
@@ -159,6 +162,16 @@ export default function Preference() { | |||||
| Zap Amount | ||||||
| </List.Item> | ||||||
|
|
||||||
|
|
||||||
| <List.Item | ||||||
| actions={[ | ||||||
|
|
||||||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
this should fixed the compiled error |
||||||
| <BitcoinButton key="btc-connect"/>, | ||||||
| ]} | ||||||
| > | ||||||
| Bitcoin Connect | ||||||
| </List.Item> | ||||||
|
|
||||||
| <Divider orientation="left">Database</Divider> | ||||||
| <List.Item | ||||||
| actions={[ | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To resolve - why could you not import bitcoin connect here? it's needed so zaps work on every page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alan-AC7 For NextJS you can add this to
src/components/PostItems/PostReactions/index.tsxto only import the library clientside: