Skip to content

Update rdf-canonize, node versions, and more. #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 20, 2025
Merged

Update rdf-canonize, node versions, and more. #548

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d10b6ab
Drop support for Node.js < 18.
davidlehn Nov 18, 2023
b1da29f
Update to `rdf-canonize@4`.
davidlehn Nov 18, 2023
598e2cc
Remove support for `application/nquads` alias.
davidlehn Nov 18, 2023
76cf794
Update dependencies.
davidlehn Nov 18, 2023
92c0808
Update actions.
davidlehn Dec 21, 2024
ceb3ab3
Update development dependencies.
davidlehn Jan 7, 2025
d6479b0
Update dependencies.
davidlehn Oct 23, 2025
a131d41
Support and test Node.js 24.x.
davidlehn Oct 23, 2025
1b5e912
Refactor test framework.
davidlehn Oct 25, 2025
805b96d
Fix browserify env vars.
davidlehn Oct 28, 2025
02d92d3
Fix test fromRdf#t0027.
davidlehn Oct 28, 2025
9d97233
Fix conditional.
davidlehn Oct 28, 2025
d0875ec
Fix useNativeTypes handling.
davidlehn Oct 29, 2025
f944de0
Update dev dependencies.
davidlehn Nov 19, 2025
95b1a52
Use `rdf-canonize@5`.
davidlehn Nov 20, 2025
67bf276
Update workflow.
davidlehn Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/fromRdf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,10 +350,12 @@ function _RDFToObject(o, useNativeTypes, rdfDirection, options) {
// use native types for certain xsd types
if(useNativeTypes) {
if(type === XSD_BOOLEAN) {
if(rval['@value'] === 'true') {
if(rval['@value'] === 'true' || rval['@value'] === '1') {
rval['@value'] = true;
} else if(rval['@value'] === 'false') {
} else if(rval['@value'] === 'false' || rval['@value'] === '0') {
rval['@value'] = false;
} else if(rval['@value'] === 'True' || rval['@value'] === 'False') {
rval['@type'] = type;
Copy link

@filip26 filip26 Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should simply be an else. In other words:

  • If the value is "true" (line 353), use the native true.
  • If the value is "false" (line 355), use the native false.
  • If it cannot be coerced to native types (i.e., not true, 1, false, or 0), keep it as is, that is, set the type to boolean, but do not convert the value to native types.
} else {
  rval['@type'] = type;
}

Copy link

@filip26 filip26 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it more, you should not get '1' or '0' from RDF.

Copy link
Member Author

@davidlehn davidlehn Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it more, you should not get '1' or '0' from RDF.

Supporting those was part of why the newer test exists. What did you mean?

This should simply be an else.

Yes, I got confused. Made a test suite PR to help clarify and handle another similar case that this code would fail on.
w3c/json-ld-api#669

Copy link

@filip26 filip26 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's confusing but please keep the test as is, see w3c/json-ld-api#669 (comment).

Your fix is almost OK, just the plain else and it should work.

}
} else if(types.isNumeric(rval['@value'])) {
if(type === XSD_INTEGER) {
Expand All @@ -364,6 +366,10 @@ function _RDFToObject(o, useNativeTypes, rdfDirection, options) {
} else if(type === XSD_DOUBLE) {
rval['@value'] = parseFloat(rval['@value']);
}
} else if(type == XSD_DOUBLE) {
// if not numeric and double, include type
// occurs for valid strings such as "+INF", "-INF", and large values
rval['@type'] = type;
}
// do not add native type
if(![XSD_BOOLEAN, XSD_INTEGER, XSD_DOUBLE, XSD_STRING].includes(type)) {
Expand Down