Implemented gradientWidth text attribute. #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkunkel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This replaces the hard-coded 100px value that's being used today. What we really want is to set this to 100% of the text width for display name styles, but that seems to involve some non-trivial rendering changes, so I'm starting with a lower impact change first by just accepting a number from the client. I'll try to get the client to calculate width dynamically at render time, and if that doesn't work well we may revisit this to add a dynamic mode to the attribute.
Previous PRs for display name styles:
Changelog:
[|INTERNAL] [ADDED] - Added support for
gradientWidthin our text attributes.Test Plan:
No user-visible changes. Regression tested locally with and without gradients on Android and iOS using test instructions.