[task] Stroke Effect Ellipsis fix #137
Open
+149
−264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insacc
force-pushed
the
task/stroke-shadow-fix-ellipsis
branch
from
3f6de77 to
3ce12ea
Compare
Add logs fix build Add more logs Add more logs Setup the stroke view on the text view Add some more logs Disable foreground color span when stroke is present Add more logs Update the stroke implementation Reset color filter for the fill pass Reeanable the foreground color span Improve the stroke style implementation Fix the text shadow style span Update the stroke style implementation Add leading margin for stroke/shadow that extends beyond text bounds Fix the build issue Fix the build
insacc
force-pushed
the
task/stroke-shadow-fix-ellipsis
branch
from
de22599 to
8f5e09b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This changes the way we handle the stroke effects on a text view because using a
ReplacementSpanfor stroke effects breaks the truncation logic otherwise. This implementation turns theStrokeStyleSpaninto aCharacterStyleto hold the data about the strokeWidth and strokeColor and let theReactTextViewhandle drawing the stroke which matches the implementation on ios as well and fixes the truncation issueRemoves the
DiscordShadowStylewe created as that was using a replacementSpan and was having the same truncation issue. Instead to solve the clipping at the left end of the text we're adding aLeadingMarginSpanto account for shadows as well as stroke effectsTried to keep most of the changes contained in the style span classes we have to make it easier for future use.
Test Plan: