feat(globals): de-duplicate timestamp formatting patterns #1440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WentTheFox
requested review from
Jiralite,
almeidx,
iCrawl,
sdanialraza and
vladfrangu
|
@WentTheFox is attempting to deploy a commit to the discordjs Team on Vercel. A member of the Team first needs to authorize it. |
WentTheFox
changed the title
This was referenced Nov 20, 2025
WentTheFox
force-pushed
the
globals-timestamps-dry
branch
4 times, most recently
from
fbf1de8 to
b483fb8
Compare
WentTheFox
force-pushed
the
globals-timestamps-dry
branch
from
b483fb8 to
06b989a
Compare
vladfrangu
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
I believe de-duplication via using the
RegExpconstructor can save some hassle when updating these formats in the future.If applicable, please reference Discord API Docs PRs or commits that influenced this PR:
StyledTimestamp#1439