fix: Create alias view errored #308
Open
+38
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR refactors alias plugin handling by adding draft-content context propagation, streamlining placeholder and plugin tree operations during alias creation, improving plugin detachment logic with accurate position and hierarchy preservation, and cleaning up unused view parameters. Sequence diagram for improved alias plugin detachmentsequenceDiagram
participant User
participant "AliasPlugin"
participant "Alias"
participant "TargetPlaceholder"
participant "SourcePlugins"
User->>AliasPlugin: Request detach_alias_plugin(plugin, language)
AliasPlugin->>Alias: get_plugins(language, show_draft_content=True)
Alias->>SourcePlugins: Return source_plugins
AliasPlugin->>TargetPlaceholder: delete_plugin(plugin)
alt SourcePlugins exist
TargetPlaceholder->>TargetPlaceholder: get_last_plugin(language)
TargetPlaceholder->>TargetPlaceholder: _shift_plugin_positions(language, start=plugin.position, offset=...)
AliasPlugin->>TargetPlaceholder: copy_plugins_to_placeholder(source_plugins, root_plugin=plugin.parent, start_positions={language: plugin.position})
end
Class diagram for updated Alias and plugin handlingclassDiagram
class Alias {
+get_placeholder(language=None, show_draft_content=False)
+get_plugins(language=None, show_draft_content=False)
}
class AliasPlugin {
+detach_alias_plugin(plugin, language)
}
class Placeholder {
+delete_plugin(plugin)
+get_last_plugin(language)
+_shift_plugin_positions(language, start, offset)
}
class CMSPlugin {
+_get_descendants_ids()
+delete()
}
AliasPlugin --> Alias : uses
AliasPlugin --> Placeholder : manipulates
Alias --> Placeholder : retrieves
Placeholder --> CMSPlugin : manages
CMSPlugin --> Placeholder : belongs to
Class diagram for updated populate logic in AliasclassDiagram
class Alias {
+populate(replaced_placeholder=None, replaced_plugin=None, plugins=None)
}
class Placeholder {
+cmsplugin_set
+_recalculate_plugin_positions(language)
}
class CMSPlugin {
+pk
+placeholder
+position
+parent
+_get_descendants_ids()
+delete()
}
Alias --> Placeholder : updates
Alias --> CMSPlugin : copies/deletes
CMSPlugin --> Placeholder : belongs to
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- In get_plugins, the cache key only includes language but not show_draft_content, so consider incorporating draft flag into the key or invalidating the cache when draft mode changes to prevent stale plugin lists.
- In detach_alias_plugin you call get_last_plugin with plugin.language but then use the language parameter for shifting—unify these to consistently use the passed-in language.
- You commented out passing source_plugin to render_replace_response in create_alias_view; ensure the downstream handler no longer requires that argument or update its signature accordingly.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In get_plugins, the cache key only includes language but not show_draft_content, so consider incorporating draft flag into the key or invalidating the cache when draft mode changes to prevent stale plugin lists.
- In detach_alias_plugin you call get_last_plugin with plugin.language but then use the language parameter for shifting—unify these to consistently use the passed-in language.
- You commented out passing source_plugin to render_replace_response in create_alias_view; ensure the downstream handler no longer requires that argument or update its signature accordingly.
## Individual Comments
### Comment 1
<location> `djangocms_alias/models.py:196` </location>
<code_context>
return getattr(content, "placeholder", None)
- def get_plugins(self, language=None):
+ def get_plugins(self, language=None, show_draft_content=False):
if not language:
language = get_language()
</code_context>
<issue_to_address>
**issue (bug_risk):** Consider updating cache key to include show_draft_content.
The cache key should account for show_draft_content to prevent returning incorrect plugin lists when this parameter varies.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix alias creation and detachment flows by adding draft content support, streamlining plugin population logic, and correcting the create_alias_view handler to prevent errors.
Bug Fixes:
Enhancements:
Fixes #306
Related resources
Checklist