Skip to content

fix: Updated CMS_Editor selector to handle tabular and stacked inlines #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Updated CMS_Editor selector to handle tabular and stacked inlines #134

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a28be7
fix: Updated CMS_Editor selector to handle tabular and stacked inline…
Nov 11, 2025
215df35
trigger GitHub Actions
Nov 12, 2025
a6c5793
Merge branch 'main' into fix/stacked-inline-multiple-instances-123
fsbraun Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions private/js/cms.editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class CMSEditor {
this._generic_editors = {};
this._admin_selector = 'textarea.CMS_Editor';
this._admin_add_row_selector = 'body.change-form .add-row a';
this._inline_admin_selector = 'body.change-form .form-row';
this._inline_admin_selector = 'body.change-form [data-inline-type="tabular"] .form-row:not(.empty-form) ' + this._admin_selector + ', body.change-form [data-inline-type="stacked"] .inline-related:not(.empty-form) ' + this._admin_selector;
this.API = {
LinkField: LinkField,
CmsDialog: CmsDialog,
Expand All @@ -44,9 +44,9 @@ class CMSEditor {
});
}

if (document.querySelector(this._inline_admin_selector + '.empty-form')) {
if (document.querySelector(this._admin_selector)?.closest('.empty-form')) {
// Marker for inline admin form: do **not** initialize empty form templates
this._admin_selector = this._inline_admin_selector + ':not(.empty-form) ' + this._admin_selector;
this._admin_selector = this._inline_admin_selector;
}
this.initAll();
}, { once: true });
Expand Down
Loading