-
Notifications
You must be signed in to change notification settings - Fork 11
feat: Add support for Django 6.0 #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
| ========= | ||
|
|
||
| Unreleased | ||
| django-fsm-2 4.1.0 unreleased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure yet if it will be released as 4.1 or 5.0 (if we manage to include the admin PR)
| django-fsm-2 4.1.0 unreleased | |
| django-fsm-2 unreleased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
I will merge it despite codecov complaining about the coverage! ;)
|
@pfouque Thanks! The missing coverage line must be spurious. I'm not sure why (aggregation?). The line claimed uncovered makes the tests pass for Django 6. Maybe there's something with the coverage config? |
|
Indeed @fsbraun, As we have just this single version-specific piece of code it's not a big issue. That's why I merged it anyway |
|
@pfouque I would like to advocate for a release... Django 6.0b1 is out now. We're considering moving our dependencies from django-fsm to django-fsm-2 right now. What do you think? Is there anyway I can help? |
This PR adds Django 6.0 compatibility and updates the test matrix.
The key change is that a model's
_do_updatemethod requires a 7th positional parameterreturning_fields.charettes/django@55a0073