Skip to content

Conversation

glen-sharp
Copy link

@glen-sharp glen-sharp commented May 25, 2025

Fixes #1430

@glen-sharp
Copy link
Author

Hiya, I saw this issue and thought it would be a good first contribution for myself. Please let me know if there are any other updates needed to the PR 👍

@sabderemane sabderemane self-assigned this Jun 8, 2025
@thibaudcolas
Copy link
Member

omg ☺️ will review!

Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A few changes to make, pretty minor. We don’t need the "changes" page / view / template, the git history is plenty enough.

</div>
{% endblock %}

{% block title %}{% translate "Django Accessibility Statement" %}{% endblock %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit puzzling to me this is at the bottom of the doc (I see this consistent with the diversity statement at least)


<dl>
<dt>{% isodate "2025-05-25" %}</dt>
<dd><a href="https://github.com/glen-sharp/djangoproject.com/commit/a26412b6076ce203023bfba2827d286e4d1d1cc8">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong commit link

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think we need this file / a separate change tracking page. There’s no need for a particularly well defined change review process.

{% endblocktranslate %}
</p>

<h2>{% translate "Our commitment" %}</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h2>{% translate "Our commitment" %}</h2>
<h2>{% translate "Our commitment" %} <a class="plink" href="#our-commitment"></a></h2>

{% endblocktranslate %}
</p>

<ul class="simple">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ul class="simple">
<ul>

doesn’t seem to do anything / be defined anywhere?

Comment on lines 86 to 88
<a href="https://code.djangoproject.com/query?description=~accessibility\&status=assigned\
&status=closed\&status=new\&or\&keywords=~accessibility\&or\&summary=~accessibility\&order=id\
&desc=1\&col=id\&col=summary\&col=owner\&col=type\&col=component">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="https://code.djangoproject.com/query?description=~accessibility\&status=assigned\
&status=closed\&status=new\&or\&keywords=~accessibility\&or\&summary=~accessibility\&order=id\
&desc=1\&col=id\&col=summary\&col=owner\&col=type\&col=component">
<a href="https://code.djangoproject.com/query?description=~accessibility&status=assigned&status=closed&status=new&or&keywords=~accessibility&or&summary=~accessibility&order=id&desc=1&col=id&col=summary&col=owner&col=type&col=component">

URL is off (was off in the live version too!), and I don’t think we’re really gaining anything by breaking this into multiple lines, just makes it harder to update the content.

Comment on lines 139 to 146
{% blocktranslate trimmed %}
We value your input. If you encounter an accessibility barrier or have suggestions for improvement and none of the
above options seem appropriate, please contact the accessibility team. Find us on:
<a href="https://forum.djangoproject.com/c/internals/accessibility/26">Accessibility on the forum</a>,
<a href="https://discord.com/channels/856567261900832808/931568482489860137">#accessibility on Discord</a>,
or if neither work for you please use the
<a href="https://www.djangoproject.com/contact/foundation/">Contact us page</a>.
{% endblocktranslate %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% blocktranslate trimmed %}
We value your input. If you encounter an accessibility barrier or have suggestions for improvement and none of the
above options seem appropriate, please contact the accessibility team. Find us on:
<a href="https://forum.djangoproject.com/c/internals/accessibility/26">Accessibility on the forum</a>,
<a href="https://discord.com/channels/856567261900832808/931568482489860137">#accessibility on Discord</a>,
or if neither work for you please use the
<a href="https://www.djangoproject.com/contact/foundation/">Contact us page</a>.
{% endblocktranslate %}
{% url 'contact_foundation' as contact_url %}
{% blocktranslate trimmed %}
We value your input. If you encounter an accessibility barrier or have suggestions for improvement and none of the
above options seem appropriate, please contact the accessibility team. Find us on:
<a href="https://forum.djangoproject.com/c/internals/accessibility/26">Accessibility on the forum</a>,
<a href="https://discord.com/channels/856567261900832808/931568482489860137">#accessibility on Discord</a>,
or if neither work for you please use the
<a href="{{ contact_url }}">Contact us page</a>.
{% endblocktranslate %}

Comment on lines 130 to 133
{% blocktranslate trimmed %}
For more information and opportunities to contribute, consider contacting the
<a href="https://www.djangoproject.com/foundation/teams/#accessibility-team">Django accessibility team</a>.
{% endblocktranslate %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% blocktranslate trimmed %}
For more information and opportunities to contribute, consider contacting the
<a href="https://www.djangoproject.com/foundation/teams/#accessibility-team">Django accessibility team</a>.
{% endblocktranslate %}
{% url 'members:teams' as teams_url %}
{% blocktranslate trimmed %}
For more information and opportunities to contribute, consider contacting the
<a href="{{ teams_url }}#accessibility-team">Django accessibility team</a>.
{% endblocktranslate %}

Comment on lines 102 to 109
{% blocktranslate trimmed %}
The <a href="https://www.djangoproject.com/foundation/teams/#accessibility-team">Django accessibility team</a>
encourages projects maintained by the Django Software Foundation to be accessible to as many people as possible,
particularly those with disabilities that make using the web more difficult. This includes
<a href="https://docs.djangoproject.com/en/5.1/faq/admin/#what-assistive-technologies-are-supported-for-using-the-admin">
testing with assistive technologies</a>, reviewing changes to Django for accessibility, updating project guidelines
and documentation, and publishing reports.
{% endblocktranslate %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% blocktranslate trimmed %}
The <a href="https://www.djangoproject.com/foundation/teams/#accessibility-team">Django accessibility team</a>
encourages projects maintained by the Django Software Foundation to be accessible to as many people as possible,
particularly those with disabilities that make using the web more difficult. This includes
<a href="https://docs.djangoproject.com/en/5.1/faq/admin/#what-assistive-technologies-are-supported-for-using-the-admin">
testing with assistive technologies</a>, reviewing changes to Django for accessibility, updating project guidelines
and documentation, and publishing reports.
{% endblocktranslate %}
{% url 'members:teams' as teams_url %}
{% url 'document-detail' lang='en' version='stable' url='faq/admin' host 'docs' as admin_faq_url %}
{% blocktranslate trimmed %}
The <a href="{{ teams_url }}#accessibility-team">Django accessibility team</a>
encourages projects maintained by the Django Software Foundation to be accessible to as many people as possible,
particularly those with disabilities that make using the web more difficult. This includes
<a href="{{ admin_faq_url }}#what-assistive-technologies-are-supported-for-using-the-admin">
testing with assistive technologies</a>, reviewing changes to Django for accessibility, updating project guidelines
and documentation, and publishing reports.
{% endblocktranslate %}

Comment on lines 118 to 122
{% blocktranslate trimmed %}
<a href="https://docs.djangoproject.com/en/dev/internals/contributing/bugs-and-features/">
Reporting accessibility issues</a> in Django's admin interface, documentation, or websites. This can also be
done on the <a href="https://forum.djangoproject.com/c/internals/accessibility/26">Django forum in accessibility</a>.
{% endblocktranslate %}</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% blocktranslate trimmed %}
<a href="https://docs.djangoproject.com/en/dev/internals/contributing/bugs-and-features/">
Reporting accessibility issues</a> in Django's admin interface, documentation, or websites. This can also be
done on the <a href="https://forum.djangoproject.com/c/internals/accessibility/26">Django forum in accessibility</a>.
{% endblocktranslate %}</li>
{% url 'document-detail' lang='en' version='dev' url='internals/contributing/bugs-and-features' host 'docs' as reporting_url %}
{% blocktranslate trimmed %}
<a href="{{ reporting_url }}">
Reporting accessibility issues</a> in Django's admin interface, documentation, or websites. This can also be
done on the <a href="https://forum.djangoproject.com/c/internals/accessibility/26">Django forum in accessibility</a>.
{% endblocktranslate %}</li>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

New content: Accessibility statement

3 participants