Skip to content

Fixed missing constexpr from enum string and similar #21489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KaruroChori
Copy link

It fixes #21487 for C++ code which was not generated properly.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @KaruroChori! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#21489"

@KaruroChori
Copy link
Author

It looks like the test-suite must be updated accordingly, but I am totally unfamiliar with the codebase, so it might take a while to prepare a usable environment.

@thewilsonator
Copy link
Contributor

You will need to update the test suite here

- compilable\dtoh_enum.d
- compilable\dtoh_enum_cpp98.d
- compilable\dtoh_functions.d
- compilable\dtoh_required_symbols.d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong C++ header generation of enum string members
3 participants