Skip to content

Pass along sass's stats object - followup #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pass along sass's stats object - followup #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fba159
Pass along sass's `stats` object
WraithKenny Jul 21, 2021
0e7adea
Update tests
niksy Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ const filePush = (file, sassObject, callback) => {
file.stat.atime = file.stat.mtime = file.stat.ctime = new Date();
}

// Pass along some potentially useful data.
file.sassStats = sassObject.stats;

callback(null, file);
};

Expand Down Expand Up @@ -105,6 +108,7 @@ const gulpSass = (options, sync) => {

if (!file.contents.length) {
file.path = replaceExtension(file.path, '.css');
file.sassStats = null;
callback(null, file);
return;
}
Expand Down
22 changes: 22 additions & 0 deletions test/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ describe('gulp-sass -- async compile', () => {
assert.ok(cssFile.path);
assert.ok(cssFile.relative);
assert.ok(cssFile.contents);
assert.equal(cssFile.sassStats, null);
assert.equal(path.basename(cssFile.path), 'empty.css');

const actual = fs.readFileSync(path.join(__dirname, expectedTestsPath, 'empty.css'), 'utf8');
Expand All @@ -92,9 +93,11 @@ describe('gulp-sass -- async compile', () => {
assert.ok(cssFile.path);
assert.ok(cssFile.relative);
assert.ok(cssFile.contents);
assert.ok(cssFile.sassStats);

const actual = fs.readFileSync(path.join(__dirname, expectedTestsPath, 'mixins.css'), 'utf8');
assert.equal(String(normaliseEOL(cssFile.contents)), normaliseEOL(actual));
assert.equal(cssFile.sassStats.includedFiles.length, 1);
done();
});
stream.write(sassFile);
Expand All @@ -114,12 +117,15 @@ describe('gulp-sass -- async compile', () => {
assert.ok(cssFile.path);
assert.ok(cssFile.relative);
assert.ok(cssFile.contents);
assert.ok(cssFile.sassStats);

if (cssFile.path.includes('variables')) {
expectedPath = path.join(expectedTestsPath, 'variables.css');
}

const actual = fs.readFileSync(path.join(__dirname, expectedPath), 'utf8');
assert.equal(String(normaliseEOL(cssFile.contents)), normaliseEOL(actual));
assert.equal(cssFile.sassStats.includedFiles.length, 1);

mustSee -= 1;
if (mustSee <= 0) {
Expand All @@ -140,9 +146,11 @@ describe('gulp-sass -- async compile', () => {
assert.ok(cssFile.path);
assert.ok(cssFile.relative);
assert.ok(cssFile.contents);
assert.ok(cssFile.sassStats);

const actual = fs.readFileSync(path.join(__dirname, expectedTestsPath, 'inheritance.css'), 'utf8');
assert.equal(String(normaliseEOL(cssFile.contents)), normaliseEOL(actual));
assert.equal(cssFile.sassStats.includedFiles.length, 3);
done();
});
stream.write(sassFile);
Expand Down Expand Up @@ -205,9 +213,11 @@ describe('gulp-sass -- async compile', () => {
assert.equal(cssFile.path.split(path.sep).pop(), 'mixin--changed.css');
assert.ok(cssFile.relative);
assert.ok(cssFile.contents);
assert.ok(cssFile.sassStats);

const actual = fs.readFileSync(path.join(__dirname, expectedTestsPath, 'mixins.css'), 'utf8');
assert.equal(String(normaliseEOL(cssFile.contents)), normaliseEOL(actual));
assert.equal(cssFile.sassStats.includedFiles.length, 1);
done();
});
stream.write(sassFile);
Expand All @@ -224,9 +234,11 @@ describe('gulp-sass -- async compile', () => {
assert.ok(cssFile.path);
assert.ok(cssFile.relative);
assert.ok(cssFile.contents);
assert.ok(cssFile.sassStats);

const actual = fs.readFileSync(path.join(__dirname, expectedTestsPath, 'mixins.css'), 'utf8');
assert.equal(String(normaliseEOL(cssFile.contents)), `/* Added Dynamically */\n${normaliseEOL(actual)}`);
assert.equal(cssFile.sassStats.includedFiles.length, 1);
done();
});
stream.write(sassFile);
Expand Down Expand Up @@ -268,9 +280,11 @@ describe('gulp-sass -- async compile', () => {
assert.ok(cssFile.path);
assert.ok(cssFile.relative);
assert.ok(cssFile.contents);
assert.ok(cssFile.sassStats);

const actual = fs.readFileSync(path.join(__dirname, expectedTestsPath, 'indent.css'), 'utf8');
assert.equal(String(normaliseEOL(cssFile.contents)), normaliseEOL(actual));
assert.equal(cssFile.sassStats.includedFiles.length, 1);
done();
});
stream.write(sassFile);
Expand All @@ -290,12 +304,14 @@ describe('gulp-sass -- async compile', () => {
assert.ok(cssFile.path);
assert.ok(cssFile.relative);
assert.ok(cssFile.contents);
assert.ok(cssFile.sassStats);
if (cssFile.path.includes('indent')) {
expectedPath = path.join(expectedTestsPath, 'indent.css');
}

const actual = fs.readFileSync(path.join(__dirname, expectedPath), 'utf8');
assert.equal(String(normaliseEOL(cssFile.contents)), normaliseEOL(actual));
assert.equal(cssFile.sassStats.includedFiles.length, 1);

mustSee -= 1;
if (mustSee <= 0) {
Expand Down Expand Up @@ -347,9 +363,11 @@ describe('gulp-sass -- sync compile', () => {
assert.ok(cssFile.path);
assert.ok(cssFile.relative);
assert.ok(cssFile.contents);
assert.ok(cssFile.sassStats);

const actual = fs.readFileSync(path.join(__dirname, expectedTestsPath, 'mixins.css'), 'utf8');
assert.equal(String(normaliseEOL(cssFile.contents)), normaliseEOL(actual));
assert.equal(cssFile.sassStats.includedFiles.length, 1);
done();
});
stream.write(sassFile);
Expand All @@ -369,13 +387,15 @@ describe('gulp-sass -- sync compile', () => {
assert.ok(cssFile.path);
assert.ok(cssFile.relative);
assert.ok(cssFile.contents);
assert.ok(cssFile.sassStats);

if (cssFile.path.includes('variables')) {
expectedPath = path.join(expectedTestsPath, 'variables.css');
}

const actual = normaliseEOL(fs.readFileSync(path.join(__dirname, expectedPath), 'utf8'));
assert.equal(String(normaliseEOL(cssFile.contents)), actual);
assert.equal(cssFile.sassStats.includedFiles.length, 1);

mustSee -= 1;
if (mustSee <= 0) {
Expand All @@ -397,9 +417,11 @@ describe('gulp-sass -- sync compile', () => {
assert.ok(cssFile.path);
assert.ok(cssFile.relative);
assert.ok(cssFile.contents);
assert.ok(cssFile.sassStats);

const actual = fs.readFileSync(path.join(__dirname, expectedTestsPath, 'inheritance.css'), 'utf8');
assert.equal(String(normaliseEOL(cssFile.contents)), normaliseEOL(actual));
assert.equal(cssFile.sassStats.includedFiles.length, 3);
done();
});
stream.write(sassFile);
Expand Down