feat: Add ability to select specific v2 API endpoints for pipedrive verified source #669
+322
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dat-a-man
added
verified source
dat-a-man
changed the title
dat-a-man
force-pushed
the
feature/update_pipedrive_source_v2_addon
branch
from
38c7ded to
4a7807f
Compare
anuunchin
requested changes
Nov 17, 2025
Collaborator
anuunchin
left a comment
anuunchin
left a comment
There was a problem hiding this comment.
@dat-a-man the imports in tests are fixed now, you should probably rebase to master for the lint ci checks to pass :)
AstrakhantsevaAA
requested changes
Nov 20, 2025
Collaborator
AstrakhantsevaAA
left a comment
AstrakhantsevaAA
left a comment
There was a problem hiding this comment.
impressive work! a few moments look off, mentioned them in comments
| "resources": cast(List[Union[str, EndpointResource, DltResource]], resources), | ||
| } | ||
|
|
||
| api_source = rest_api_source(config) |
Collaborator
There was a problem hiding this comment.
you can use rest_api_resources instead and skip this for-loop and double dlt.source initialisation
https://dlthub.com/docs/dlt-ecosystem/verified-sources/rest_api/basic#quick-example-1
|
|
||
| api_source = rest_api_source(config) | ||
| for resource in api_source.resources.values(): | ||
| yield resource.with_name(f"{prefix}{resource.name}") |
Collaborator
There was a problem hiding this comment.
why you do that here?
in lines 103-104 you can do the same without extra loops:
nested_resource_def: Dict[str, Any] = {
"name": f"{prefix}{nested_name}",
to be used in the Pipedrive source. Users can now configure this by passing a list of endpoint names to the `use_v2_endpoints` parameter. This allows for a gradual migration to v2 without enabling all endpoints at once. fix: clean whitespace and update pipedrive v2 source Revised structure for lint errors and making it simpler minor fixes
dat-a-man
force-pushed
the
feature/update_pipedrive_source_v2_addon
branch
from
0fc37aa to
39affb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used in the Pipedrive source.
Users can now configure this by passing a list of endpoint names to the
use_v2_endpointsparameter. This allows for a gradual migration to v2 without enabling all endpoints at once.