-
Notifications
You must be signed in to change notification settings - Fork 3
sign github actions cache blobs #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9591c5c to
84847ab
Compare
90030b4 to
3408a90
Compare
.github/workflows/build.yml
Outdated
| env: | ||
| BUILDX_VERSION: "v0.30.1" | ||
| BUILDKIT_IMAGE: "moby/buildkit:v0.26.2" | ||
| BUILDKIT_IMAGE: "crazymax/buildkit:6397" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in draft until moby/buildkit#6397 is released
| timestampTreshold = 1 | ||
| tlogThreshold = ${{ matrix.tlogUpload && '1' || '0' }} | ||
| subjectAlternativeName = "https://github.com/docker/github-builder-experimental/.github/workflows/bake.yml*" | ||
| issuer = "https://token.actions.githubusercontent.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to verify source repo, build repo (same as san) and I think also ref (master branch/tag should not verify PR cache)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added, see aeba44b
cd6b852 to
6d3e37f
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
6d3e37f to
ff3b622
Compare
| env: | ||
| BUILDX_VERSION: "v0.30.1" | ||
| BUILDKIT_IMAGE: "moby/buildkit:v0.26.2" | ||
| BUILDKIT_IMAGE: "moby/buildkit:master@sha256:bdefeba47634c596286beabe68219708ed364c4f1a5e4e9a2e160274712a0e89" # TODO: pin to a specific version when signed gha cache feature is available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tonistiigi As discussed pin buildkit image to master
follow-up moby/buildkit#6397
fixes #56
Enabling signing for cache blobs in GHA cache backend protects against tampering of remote cache. The approach used here keeps the implementation isolated, transparent, and cost-effective. Local testing shows that the additional overhead introduced by copying the cosign binary into the builder container is negligible.