feat: Remove legacy CvatDatasetBuilder code, use modernized code #174
+1,399
−3,095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
…n_groundtruth Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
Replace legacy CVAT annotation processing code (~1400 lines) with modern convert_cvat_folder_to_docling() converter in CvatDatasetBuilder. This significantly simplifies the codebase and aligns with the modern CVAT converter architecture. - Remove legacy annotation parsing and document creation methods - Use convert_cvat_folder_to_docling() for CVAT-to-Docling conversion - Improve path handling in CvatPreannotationBuilder for moved datasets - Remove unused original and original_prediction storage in json_dataset_joiner - Update test data annotations to match new converter output BREAKING CHANGE: CvatDatasetBuilder now requires modern CVAT folder structure and uses convert_cvat_folder_to_docling() internally. Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Contributor
|
✅ DCO Check Passed Thanks @cau-git, all your commits are properly signed off. 🎉 |
Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
cau-git
changed the title
cau-git
requested review from
PeterStaar-IBM,
Saidgurbuz,
maxmnemonic and
nikos-livathinos
- Refactor cvat_deliveries_to_hf to build single combined dataset with subset tags - Add tags field to DatasetRecord for subset tracking - Add page counting to annotation task creation - Support multipage TIFF and additional image formats (BMP, GIF) - Add configurable JSON directory names to pipeline - Fix caption/footnote target detection logic in CVAT converter Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
…eannotation_cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.