Skip to content

feat: support relative path with target config. #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sy-records merged 11 commits into from
Apr 28, 2024
Merged

feat: support relative path with target config. #1751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eea65bf
enhance: support relative path with target config.
Koooooo-7 Feb 14, 2022
3e1151f
Merge branch 'develop' into feat-target
Koooooo-7 Mar 4, 2022
a7b51bf
Merge branch 'develop' into feat-target
jhildenbiddle Mar 7, 2022
2f5eb97
Merge branch 'develop' into feat-target
Koooooo-7 Mar 19, 2022
5373eca
Update link.js
Koooooo-7 Mar 21, 2022
76c7587
Update render.test.js
Koooooo-7 Mar 23, 2022
53b7058
Merge branch 'develop' into feat-target
trusktr Mar 23, 2022
628690e
Merge branch 'develop' into feat-target
Koooooo-7 Aug 6, 2022
bb2d838
Merge branch 'develop' into feat-target
Koooooo-7 Mar 4, 2024
6464167
Merge branch 'develop' into feat-target
Koooooo-7 Apr 20, 2024
80c2ee6
Merge branch 'develop' into feat-target
jhildenbiddle Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/core/render/compiler/link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ export const linkCompiler = ({
}

href = router.toURL(href, null, router.getCurrentPath());

if (config.target) {
href.indexOf('mailto:') !== 0 && attrs.push(`target="${linkTarget}"`);
}
} else {
if (!isAbsolutePath(href) && href.slice(0, 2) === './') {
href =
Expand Down
10 changes: 9 additions & 1 deletion test/integration/render.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,14 +253,22 @@ describe('render', function () {
);
});

test('target', async function () {
test('target for absolute path', async function () {
const output = window.marked("[alt text](http://url ':target=_self')");

expect(output).toMatchInlineSnapshot(
`"<p><a href=\\"http://url\\" target=\\"_self\\" >alt text</a></p>"`
);
});

test('target for relative path', async function () {
const output = window.marked("[alt text](/url ':target=_blank')");

expect(output).toMatchInlineSnapshot(
`"<p><a href=\\"#/url\\" target=\\"_blank\\">alt text</a></p>"`
);
});

test('class', async function () {
const output = window.marked(
"[alt text](http://url ':class=someCssClass')"
Expand Down