-
Notifications
You must be signed in to change notification settings - Fork 63
Linear damping #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chris838
wants to merge
27
commits into
domhofmann:master
Choose a base branch
from
chris838:linear-damping
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Linear damping #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(still a bit hackish though but at least now it doesn't mess up with the All Exceptions breakpoint)
Formatted code for better readability (at least for me)
+ added a removeAllTweenOperations
…entTrackingRunLoopMode completed, as when a UITableView or UIScrollView is scrolling. Added support for NSRunLoopCommonModes in calls to performSelector and with the NSTimer.
Conflicts: lib/PRTween.h lib/PRTween.m
Fix for removing all running ops
FIX: NSRunLoop issue where animations would not fire until after NSEvent...
Warning analyzer fixes
…esguillemin-master Conflicts: lib/PRTween.h lib/PRTween.m lib/PRTweenTimingFunctions.m
…can now detect if an operation was preempted using removeTweenOperation or removeAllTweenOperations.
Added finished BOOL parameter to operation completion handler
Updated example app to use new completion block type.
|
Included in https://github.com/PRTween/PRTween. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing around with linear damping as an alternative to the elastic tween timing functions. I have some code that is able to better mimic (I think) the iOS UIView spring animation:
https://developer.apple.com/library/ios/documentation/uikit/reference/uiview_class/uiview/uiview.html#//apple_ref/occ/clm/UIView/animateWithDuration:delay:usingSpringWithDamping:initialSpringVelocity:options:animations:completion:
Currently it is not a really timing function since the duration parameter is ignored. If the duration could be incorporated then I think this would come very close to how Apple implements their function internally.