Update diagnostics documentation #36217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the date and improved clarity in diagnostics instructions.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Blazor WebAssembly Event Pipe diagnostics documentation to improve developer experience and best practices. The changes address issue #36216 by adding MSBuild conditions to restrict diagnostic features to Debug builds and providing clearer guidance on file locations.
Key changes:
- Added MSBuild conditions to all diagnostic PropertyGroup elements to limit diagnostics to Debug builds only
- Specified that
.nettracefiles are typically downloaded to the Downloads folder on Windows - Enhanced the metrics collection section with an example showing how to collect custom lifecycle meter data
Comments suppressed due to low confidence (1)
aspnetcore/blazor/performance/webassembly-event-pipe-diagnostics.md:89
- Corrected spelling of 'devoloper' to 'developer'.
Call the preceding API from either a browser devoloper tools console or JavaScript code of the app.
aspnetcore/blazor/performance/webassembly-event-pipe-diagnostics.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/performance/webassembly-event-pipe-diagnostics.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pavelsavara
reviewed
Oct 14, 2025
aspnetcore/blazor/performance/webassembly-event-pipe-diagnostics.md
Outdated
Show resolved
Hide resolved
Updated warnings and conditions for enabling diagnostics in production to clarify performance impacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36216
Pavel ... In addition to the new command example, can we also specify the
Downloadsfolder for Windows because that's where the.nettracefiles go (usually, I guess)?... and all entries in the
.nettracefiles that I'm generating only showmeterNames ofSystem.Runtime.Internal previews