Enhance Blazor Not Found responses documentation #36224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the ASP.NET Core 10 release notes for Blazor by clarifying how apps without Blazor’s router can handle Not Found responses and adjusts the illustrative code snippet accordingly.
- Clarifies two supported approaches (StatusCodePages re-execution and router event handling) for rendering Not Found pages.
- Refines language and simplifies the sample by replacing reflection with a helper method to produce the Not Found path.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ilonatommy
reviewed
Oct 16, 2025
|
@ilonatommy ... How about this (last commit)? |
ilonatommy
reviewed
Oct 17, 2025
ilonatommy
approved these changes
Oct 17, 2025
Clarify the precedence of Not Found path handling in Blazor.
|
Just a couple of tiny NITs that I updated on the last commit ...
|
|
Ok, cool. 👍 I'll circle back around to the article updates right after we get the Routing and Nav article split on #36145. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #36223
Ilona ... Two things ......
See my small code changes ... see if they make sense or if I should revert them back to your suggested code.
Let's do this in two steps (this is an "addresses" PR) because I'm waiting on @danroth27 to review Split the Routing & Navigation article (
dotnet/AspNetCore.Docs#36145). That PR is a BeAsT 👹 with a lot of content moving around, so let's only work the release notes side on this PR. I'll open a new PR after 36145 merges to close out your issue.Thx! That speeds us UP. 🏃♂️Now, if I could just learn how to write software properly! 🙈😆