Improve client registration guidance #49938
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwolfmsft
commented
Nov 18, 2025
|
|
||
| // Set a credential for all clients to use by default | ||
| DefaultAzureCredential credential = new(); | ||
| clientBuilder.UseCredential(credential); |
Contributor
Author
There was a problem hiding this comment.
I believe this implementation needs to stay due to the custom client factory.
Member
There was a problem hiding this comment.
@jsquire The AOAI client registration below should use the same DefaultAzureCredential. With that in mind, how do you advise we update this code sample?
@alexwolfmsft It doesn't need to happen in this PR, but the AOAI package should be replaced with OAI.
Member
There was a problem hiding this comment.
The OpenAI registration should be updated, one of the ignored parameters from the factory is the credential to use:
lientBuilder.AddClient<AzureOpenAIClient, AzureOpenAIClientOptions>(
(options, omgUseThisCredential, _) =>new AzureOpenAIClient(
new Uri("<url_here>"), omgUseThisCredential, options)); If we do that the right way, then we can keep or kill UseCredential because we're not relying on the closure scope.
alexwolfmsft
commented
Nov 18, 2025
|
|
||
| // Set a credential for all clients to use by default | ||
| DefaultAzureCredential credential = new(); | ||
| clientBuilder.UseCredential(credential); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)
Internal previews