Skip to content

Conversation

@rainsxng
Copy link
Contributor

@rainsxng rainsxng commented Oct 2, 2025

As per following API proposal, this PR exposes the DownstreamDependencyMetadataManager class with the new name that allows you to configure the downstream dependency metadata resolution and brings more flexibility into the flow

Microsoft Reviewers: Open in CodeFlow

@rainsxng rainsxng changed the title new metadata resolver api HttpDependencyMetadataResolver class for the custom downstream dependency metadata resolution Oct 22, 2025
@rainsxng rainsxng marked this pull request as ready for review October 22, 2025 15:19
@rainsxng rainsxng requested a review from a team as a code owner October 22, 2025 15:19
Copilot AI review requested due to automatic review settings October 22, 2025 15:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the downstream dependency metadata resolution system by introducing a new public API HttpDependencyMetadataResolver to replace the internal IDownstreamDependencyMetadataManager interface. The changes expose the dependency metadata resolution functionality with improved naming and flexibility.

  • Renames internal DownstreamDependencyMetadataManager to public HttpDependencyMetadataResolver as an abstract class
  • Adds DefaultHttpDependencyMetadataResolver as the default implementation
  • Updates registration methods to use TryAddEnumerable for proper DI behavior with multiple metadata instances

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
HttpDependencyMetadataResolver.cs Converts internal sealed class to public abstract class with documentation and removes obsolete HttpWebRequest support
DefaultHttpDependencyMetadataResolver.cs New sealed class providing default implementation of the resolver
HttpDiagnosticsServiceCollectionExtensions.cs Updates registration to use TryAddEnumerable and adds new AddStandardHttpDependencyMetadataResolver method
HttpRequestReader.cs Updates field and parameter names to use new resolver type
IDownstreamDependencyMetadataManager.cs Marks internal interface as obsolete
DownstreamDependencyMetadataManagerTests.cs Updates test class to use new resolver type and namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants