-
Notifications
You must be signed in to change notification settings - Fork 841
HttpDependencyMetadataResolver class for the custom downstream dependency metadata resolution #6880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the downstream dependency metadata resolution system by introducing a new public API HttpDependencyMetadataResolver to replace the internal IDownstreamDependencyMetadataManager interface. The changes expose the dependency metadata resolution functionality with improved naming and flexibility.
- Renames internal
DownstreamDependencyMetadataManagerto publicHttpDependencyMetadataResolveras an abstract class - Adds
DefaultHttpDependencyMetadataResolveras the default implementation - Updates registration methods to use
TryAddEnumerablefor proper DI behavior with multiple metadata instances
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| HttpDependencyMetadataResolver.cs | Converts internal sealed class to public abstract class with documentation and removes obsolete HttpWebRequest support |
| DefaultHttpDependencyMetadataResolver.cs | New sealed class providing default implementation of the resolver |
| HttpDiagnosticsServiceCollectionExtensions.cs | Updates registration to use TryAddEnumerable and adds new AddStandardHttpDependencyMetadataResolver method |
| HttpRequestReader.cs | Updates field and parameter names to use new resolver type |
| IDownstreamDependencyMetadataManager.cs | Marks internal interface as obsolete |
| DownstreamDependencyMetadataManagerTests.cs | Updates test class to use new resolver type and namespace |
As per following API proposal, this PR exposes the
DownstreamDependencyMetadataManagerclass with the new name that allows you to configure the downstream dependency metadata resolution and brings more flexibility into the flowMicrosoft Reviewers: Open in CodeFlow