Preserve function content in SummarizingChatReducer
#6908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Fixes an issue in SummarizingChatReducer where function call content was being removed even when not summarized. The PR preserves function call and result content in the returned message list and improves message boundary detection to avoid orphaning assistant responses from their user messages.
Key changes:
- Preserves
FunctionCallContentandFunctionResultContentin message lists - Implements backward search within threshold window for user message boundaries
- Updates logic to keep complete function call sequences together
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Libraries/Microsoft.Extensions.AI/ChatReduction/SummarizingChatReducer.cs |
Core implementation changes to preserve function content and improve message boundary detection |
test/Libraries/Microsoft.Extensions.AI.Tests/ChatReduction/SummarizingChatReducerTests.cs |
Updated and added tests to verify function content preservation and threshold behavior |
src/Libraries/Microsoft.Extensions.AI/ChatReduction/SummarizingChatReducer.cs
Show resolved
Hide resolved
stephentoub
reviewed
Oct 10, 2025
src/Libraries/Microsoft.Extensions.AI/ChatReduction/SummarizingChatReducer.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 10, 2025
src/Libraries/Microsoft.Extensions.AI/ChatReduction/SummarizingChatReducer.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Oct 20, 2025
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Oct 21, 2025
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Oct 21, 2025
jeffhandley
pushed a commit
to jeffhandley/extensions
that referenced
this pull request
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where
SummarizingChatReduceralways removes function call content, even if it didn't get summarized.Description
This PR makes the following changes to
SummarizingChatReducer:FunctionCallContentandFunctionResultContentnow get preserved in the returned message list.targetCount + thresholdmessages.Fixes #6890
Microsoft Reviewers: Open in CodeFlow