Skip to content

Conversation

Epica3055
Copy link
Member

@Epica3055 Epica3055 commented Jul 16, 2025

Back port PR10243 to release/8.0

Fixes #7154 , #13672 on .Net 8.0

Microsoft Reviewers: Open in CodeFlow

Proposed changes

  • Creates a new switch that allows developers to configure their application to make the starting index of rows/cells in DataGridView to be read by Narrator from 1, instead of 0;
  • Adds checks on rows and cells of DataGridView to see if the switch is true. If true, starting index of rows/cells will be 1, instead of 0.

Customer Impact

  • Developers will be able to configure their WinForms DataGridView rows/cells to be read by Narrator from index 1, instead of 0.

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Manual (Narrator, NVDA)
  • Unit tests

@Epica3055 Epica3055 changed the title Fixes #7154 #13672 Allows DataGridView to start row/column on index 1 on Narrator [release/8.0] Fixes #7154 #13672 Allows DataGridView to start row/column on index 1 on Narrator Jul 17, 2025
@LeafShi1 LeafShi1 added waiting-review This item is waiting on review by one or more members of team waiting-on-team This work item needs to be discussed with team or is waiting on team action in order to proceed labels Jul 23, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

@Epica3055 Epica3055 added the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 24, 2025
@LeafShi1
Copy link
Member

LeafShi1 commented Aug 6, 2025

This fix does not require backporting to .net8.0

@LeafShi1 LeafShi1 closed this Aug 6, 2025
@dotnet-policy-service dotnet-policy-service bot removed waiting-on-team This work item needs to be discussed with team or is waiting on team action in order to proceed waiting-review This item is waiting on review by one or more members of team labels Aug 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants