Skip to content

Conversation

@superjax
Copy link
Contributor

@superjax superjax commented Oct 4, 2019

No description provided.

@superjax superjax force-pushed the ClangFormat branch 6 times, most recently from 0aea564 to 931a3eb Compare October 4, 2019 03:56
@superjax
Copy link
Contributor Author

superjax commented Oct 4, 2019

I have a new interface-based callback mechanism that I'd like to pr, but since I am using VScode, I can't help but have it generate a ton of whitespace changes.

I figured you'd appreciate the cleanup anyways :)

@superjax superjax mentioned this pull request Oct 4, 2019
@dpkoch
Copy link
Owner

dpkoch commented Oct 7, 2019

Thanks @superjax. This is probably great, but I'm not entirely clear on what's actually new...

Is this one only clang-format stuff? Is there some extension in VScode that's reformatting code for you? I develop this in VScode and it doesn't make changes for me. Doing a clang-format thing would probably be great, but this is also mangling a few things I don't want mangled. For now, would it possible for you to turn off whatever extension is changing stuff, then redo #9?

@superjax
Copy link
Contributor Author

superjax commented Oct 10, 2019

Sure thing!

All you do is add "editor.formatOnSave": true, to the settings.json and install the Clang-format extension.

Or you can run it against the whole directory with

find . -iname "*.h" -o -iname "*.cpp" | xargs clang-format -i

What is the formatter doing that you don't like? It's pretty easy to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants