Skip to content

Always use config to set default value of timeout in check version #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sunnyakaxd wants to merge 1 commit into from
Closed

Always use config to set default value of timeout in check version #2108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion kafka/client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,7 @@ def get_api_versions(self):
"""
return self._api_versions

def check_version(self, node_id=None, timeout=2, strict=False):
def check_version(self, node_id=None, timeout=None, strict=False):
"""Attempt to guess the version of a Kafka broker.

Note: It is possible that this method blocks longer than the
Expand All @@ -885,6 +885,9 @@ def check_version(self, node_id=None, timeout=2, strict=False):
UnrecognizedBrokerVersion: please file bug if seen!
AssertionError (if strict=True): please file bug if seen!
"""
if timeout is None:
timeout = self.config['api_version_auto_timeout_ms'] / 1000

self._lock.acquire()
end = time.time() + timeout
while time.time() < end:
Expand Down