DP-499 Integrateio sso #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmun
reviewed
Jul 6, 2022
| /** @noinspection PhpUndefinedFieldInspection */ | ||
| $user->last_login_date = Carbon::now()->toDateTimeString(); | ||
| /** @noinspection PhpUndefinedFieldInspection */ | ||
| $user->confirm_code = 'y'; |
There was a problem hiding this comment.
What's this y? Is it not an issue if it's the same value for all users? I see confirm_code which is usually a security feature, so I am just wondering.
@tomonorman @krishnapriawan
Contributor
Author
There was a problem hiding this comment.
It just means the user is "confirmed" (yes, no) rather than an actual "code" so to speak.
daniilly
force-pushed
the
develop
branch
4 times, most recently
from
8d2da3e to
c91d00a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.