Skip to content

handle case where input might not be found and app crashes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasonbodie wants to merge 5 commits into
base: master
Choose a base branch
from
Open

handle case where input might not be found and app crashes #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9eb7d81
handle case where input might not be found and app crashes
Jul 26, 2016
4a7b7c7
guarding for support of ios 10 drag and drop
Sep 8, 2016
69d3235
attempt at fixing the positioning issue
Sep 8, 2016
90a4ea9
reving the podspec
Sep 8, 2016
cb245fd
oops ARGH
Sep 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DraggableCollectionView.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "DraggableCollectionView"
s.version = "0.1.3"
s.version = "0.1.4"
s.summary = "Extension for the UICollectionView and UICollectionViewLayout that allows a user to move items with drag and drop."
s.homepage = "https://github.com/lognllc/DraggableCollectionView"
s.license = { :type => 'MIT', :file => 'LICENSE' }
Expand Down
20 changes: 12 additions & 8 deletions DraggableCollectionView/Helpers/LSCollectionViewHelper.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,14 @@ - (id)initWithCollectionView:(UICollectionView *)collectionView
initWithTarget:self action:@selector(handlePanGesture:)];
_panPressGestureRecognizer.delegate = self;
[_collectionView addGestureRecognizer:_panPressGestureRecognizer];

for (UIGestureRecognizer *gestureRecognizer in _collectionView.gestureRecognizers) {
if ([gestureRecognizer isKindOfClass:[UILongPressGestureRecognizer class]]) {
[gestureRecognizer requireGestureRecognizerToFail:_longPressGestureRecognizer];
break;
}
}

// iOS 10 comment out to support drag and drop
// for (UIGestureRecognizer *gestureRecognizer in _collectionView.gestureRecognizers) {
// if ([gestureRecognizer isKindOfClass:[UILongPressGestureRecognizer class]]) {
// [gestureRecognizer requireGestureRecognizerToFail:_longPressGestureRecognizer];
// break;
// }
// }

[self layoutChanged];
}
Expand Down Expand Up @@ -321,7 +322,10 @@ - (void)handleLongPressGesture:(UILongPressGestureRecognizer *)sender

- (void)warpToIndexPath:(NSIndexPath *)indexPath
{
if(indexPath == nil || [lastIndexPath isEqual:indexPath]) {
if( indexPath == nil
|| [ lastIndexPath isEqual: indexPath ]
|| indexPath.item > [ self.collectionView numberOfItemsInSection: indexPath.section ] - 1 )
{
return;
}
lastIndexPath = indexPath;
Expand Down