Refactor build and run modules for improved structure and clarity #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed methods for consistency and clarity (e.g., `build_custrom` to `build_custom`, `perpare_build_config` to `prepare_build_config`). - Introduced `CargoRunnerKind` enum to encapsulate QEMU and U-Boot configurations. - Moved cargo-related functionality from `cargo.rs` to `cargo_builder.rs` for better separation of concerns. - Consolidated path management into `PathConfig` struct, simplifying path handling throughout the application. - Updated `AppContext` to use the new `PathConfig` structure, removing direct references to paths. - Enhanced error handling and path normalization in build and run processes. - Removed deprecated `cargo.rs` file and adjusted references accordingly. - Updated TFTP and U-Boot implementations to utilize the new path management structure.
ZR233
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_custromtobuild_custom,perpare_build_configtoprepare_build_config).CargoRunnerKindenum to encapsulate QEMU and U-Boot configurations.cargo.rstocargo_builder.rsfor better separation of concerns.PathConfigstruct, simplifying path handling throughout the application.AppContextto use the newPathConfigstructure, removing direct references to paths.cargo.rsfile and adjusted references accordingly.