Improve build and bump supported versions #66
Conversation
`six` isn't listed as a dependency of this package, and Python 2 is end-of-life for several years anyway, so just switch to this method name which works in all maintained Python versions.
- Fix the build so it runs on Travis, and runs for all supported Python and Django versions; - DRY things up a bit, so dependencies are installed in one place, the Travis config uses Tox rather than independent configuration etc.; - update test dependencies to latest versions; - update supported Python and Django versions to only those that are currently maintained; - some minor YAML/Python formatting.
This would have surfaced the issue fixed by dstufft#65, and ensures there is actually test coverage for `get_dictionary_words`. As such, this also means tests will fail until that PR is merged as well.
| - "3.7" | ||
| - "3.8" | ||
| - "3.9" | ||
| - "3.10" |
There was a problem hiding this comment.
These are the currently supported Python versions according to https://www.python.org/downloads/
| py37-dj{22,32} | ||
| py38-dj{22,32,40} | ||
| py39-dj{22,32,40} | ||
| py310-dj{32,40} |
There was a problem hiding this comment.
These are the currently supported Django versions, with compatible Python versions, according to https://www.djangoproject.com/download/
| @@ -1,29 +1,24 @@ | |||
| dist: focal | |||
There was a problem hiding this comment.
Travis runs on an old version (16) of Ubuntu by default, and some things didn't work with these changes on this, this switches to Ubuntu 20 which seems to work fine
There was a problem hiding this comment.
I don't actually know if you're still using Travis - the latest build I see linked from the README is https://travis-ci.org/github/dstufft/django-passwords/builds/751467158, which failed a year ago, and I don't see CI setup for PRs - possibly this was dropped when Travis scaled back their free plans? In any case, these changes should improve the build if you do want to use this, or could at least serve as a starting point to switch to using GitHub actions or similar in future
|
Not sure you'll get much movement on this. See: #59 Might be more worthwhile to fork the repo and create a derivative pypi package. |
…-versions' Merging dstufft#66 into our fork.
2 participants
This PR improves and fixes the testing/build setup, and updates the supported Python/Django versions to those that are currently maintained. I made these changes as part of investigating the issue in #65, as well as confirming to my satisfaction that this library works on more recent Python/Django versions as part of updating my own project. See each commit and the inline comments for full details of the changes being made and why.
You can see an example build for these changes, with #65 merged as well (otherwise tests would fail), here: https://app.travis-ci.com/github/bobwhitelock/django-passwords/builds/248969588