Skip to content

Duck.ai: Tabs lifecycle #7131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 19, 2025
Merged

Duck.ai: Tabs lifecycle #7131

merged 8 commits into from
Nov 19, 2025

Conversation

@malmstein
Copy link
Contributor

@malmstein malmstein commented Nov 17, 2025 •
edited by joshliebe
Loading

Task/Issue URL: https://app.asana.com/1/137249556945/task/1211821284193230

Description

This PR ensures that opening links in Duck.ai mode are stored as Tabs and can be shown as such in the Tab Manager

Steps to test this PR

Enable Fullscreen mode in AI Features

Input Screen disabled - New Tab

  • Fresh install, ensure Duck.ai is enabled
  • Open New Tab
  • Open Duck.ai from the Omnibar (Duck icon)
  • Verify Duck.ai loads in the same screen
  • Open Tab Manager
  • Verify tab is displayed as Duck.ai and there’s a preview image of the chat

Input Screen disabled - Browser

  • Fresh install, ensure Duck.ai is enabled
  • Open New Tab and navigate to any website
  • Open Duck.ai from the Omnibar (Duck icon)
  • Verify Duck.ai loads in the same screen
  • Open Tab Manager
  • Verify tab is displayed as Duck.ai and there’s a preview image of the chat

Browser Menu - New Tab

  • Fresh install, ensure Duck.ai is enabled
  • Open New Tab
  • Open Browser Menu and tap on Duck.ai
  • Verify Duck.ai loads in the same screen
  • Open Tab Manager
  • Verify tab is displayed as Duck.ai and there’s a preview image of the chat

Browser Menu - Browser

  • Fresh install, ensure Duck.ai is enabled
  • Open New Tab and navigate to any website
  • Open Browser Menu and tap on Duck.ai
  • Verify Duck.ai loads in the same screen
  • Open Tab Manager
  • Verify tab is displayed as Duck.ai and there’s a preview image of the chat

Input Screen enabled - New Tab

  • Fresh install, ensure Duck.ai is enabled and also Search & Duck.ai mode
  • Open New Tab
  • Enter a query from the Input Screen in Duck.ai mode
  • Verify Duck.ai loads
  • Open Tab Manager
  • Verify tab is displayed as Duck.ai and there’s a preview image of the chat

Input Screen enabled - Browser

  • Fresh install, ensure Duck.ai is enabled
  • Open New Tab and navigate to any website
  • Enter a query from the Input Screen in Duck.ai mode
  • Verify Duck.ai loads
  • Open Tab Manager
  • Verify tab is displayed as Duck.ai and there’s a preview image of the chat

@malmstein Graphite App
Copy link
Contributor Author

malmstein commented Nov 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@malmstein malmstein requested a review from joshliebe November 18, 2025 07:54
@malmstein malmstein marked this pull request as ready for review November 18, 2025 07:55
@malmstein malmstein force-pushed the feature/david/11-14-duck.ai_tabs_lifecycle branch from cc98aa0 to 93c224b Compare November 19, 2025 08:11
@malmstein malmstein force-pushed the feature/david/11-14-duck.ai_tabs_lifecycle branch from 93c224b to 6580b4d Compare November 19, 2025 16:51
joshliebe
joshliebe approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well 🙂 LGTM 🚀

@malmstein malmstein merged commit c685c68 into develop Nov 19, 2025
7 checks passed
@malmstein malmstein deleted the feature/david/11-14-duck.ai_tabs_lifecycle branch November 19, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshliebe joshliebe joshliebe approved these changes

Assignees

@joshliebe joshliebe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@malmstein @joshliebe