-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add sync promo to "bookmark added" dialog #7136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CDRussell
merged 3 commits into
develop
from
feature/craig/add_sync_promo_to_bookmark_added_dialog
Nov 20, 2025
Merged
Add sync promo to "bookmark added" dialog #7136
CDRussell
merged 3 commits into
develop
from
feature/craig/add_sync_promo_to_bookmark_added_dialog
Nov 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
43713d1 to
95b619f
Compare
cab4cde to
3ec24eb
Compare
95b619f to
1ed4553
Compare
3ec24eb to
c61a05c
Compare
c61a05c to
f06d284
Compare
1ed4553 to
0f365e4
Compare
6f6b0cb to
2c50b92
Compare
CDRussell
commented
Nov 19, 2025
sync/sync-impl/src/main/java/com/duckduckgo/sync/impl/promotion/SyncPromotionDataStore.kt
Show resolved
Hide resolved
CDRussell
commented
Nov 19, 2025
sync/sync-impl/src/main/java/com/duckduckgo/sync/impl/promotion/SyncPromotionFeature.kt
Outdated
Show resolved
Hide resolved
CDRussell
commented
Nov 19, 2025
sync/sync-impl/src/main/java/com/duckduckgo/sync/impl/ui/SyncInternalSettingsActivity.kt
Show resolved
Hide resolved
2c50b92 to
343bf34
Compare
343bf34 to
9279f1a
Compare
...java/com/duckduckgo/sync/impl/promotion/bookmarks/addeddialog/SetupSyncBookmarkAddedPromo.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/bookmarks/dialog/BookmarkAddedConfirmationDialog.kt
Outdated
Show resolved
Hide resolved
CrisBarreiro
approved these changes
Nov 20, 2025
app/src/main/java/com/duckduckgo/app/bookmarks/dialog/BookmarkAddedConfirmationDialogFactory.kt
Outdated
Show resolved
Hide resolved
5148142 to
d94ad28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/task/1211704631712055
Description
Adds a way for users adding a bookmark to see that they can sync bookmarks. Only shows if:
syncPromotion.bookmarkAddedDialogandsyncPromotionSteps to test this PR
Sync disabled
internalbuild typeAdd BookmarkEdit Bookmarkand then delete it. Return to browser.Sync & BackupSync already enabled
Add BookmarkFeature disabled
syncPromotion.bookmarkAddedDialogAdd BookmarkPermanently dismiss
Add BookmarkHide