Skip to content

Conversation

@CDRussell
Copy link
Member

@CDRussell CDRussell commented Nov 18, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/task/1211704631712055

Description

Adds a way for users adding a bookmark to see that they can sync bookmarks. Only shows if:

  • user does not have sync set up already
  • user has never dismissed it before
  • feature flag is enabled for both syncPromotion.bookmarkAddedDialog and syncPromotion
Screenshot_20251119_163058

Steps to test this PR

Sync disabled

  • Fresh install on internal build type
  • Visit a site, and use overflow to Add Bookmark
  • Confirm the dialog contains the option to jump to sync
  • Let the dialog auto-dismiss (after ~3.5s)
  • Use overflow to Edit Bookmark and then delete it. Return to browser.
  • Add bookmark again; confirm again the promo line is still shown and this time tap on it; verify it takes you to Sync & Backup

Sync already enabled

  • Set up sync
  • Visit a site, and use overflow to Add Bookmark
  • Verify the sync promo is NOT shown

Feature disabled

  • Fresh install
  • Use feature flag inventory to disable syncPromotion.bookmarkAddedDialog
  • Visit a site, and use overflow to Add Bookmark
  • Verify the sync promo is NOT shown

Permanently dismiss

  • Fresh install
  • Visit a site, and use overflow to Add Bookmark
  • Tap on the promo's overflow and choose to Hide
  • Verify it disappears
  • Bring up the dialog again and verify it doesn't reappear

Copy link
Member Author

CDRussell commented Nov 18, 2025

@CDRussell CDRussell force-pushed the feature/craig/add_sync_promo_to_bookmark_added_dialog branch from 43713d1 to 95b619f Compare November 18, 2025 12:04
@CDRussell CDRussell force-pushed the feature/craig/make_bookmark_added_dialog_less_generic_v3_l10n branch from cab4cde to 3ec24eb Compare November 18, 2025 12:04
@CDRussell CDRussell force-pushed the feature/craig/add_sync_promo_to_bookmark_added_dialog branch from 95b619f to 1ed4553 Compare November 19, 2025 11:16
@CDRussell CDRussell force-pushed the feature/craig/make_bookmark_added_dialog_less_generic_v3_l10n branch from 3ec24eb to c61a05c Compare November 19, 2025 11:16
@CDRussell CDRussell changed the base branch from feature/craig/make_bookmark_added_dialog_less_generic_v3_l10n to graphite-base/7136 November 19, 2025 11:44
@CDRussell CDRussell force-pushed the feature/craig/add_sync_promo_to_bookmark_added_dialog branch from 1ed4553 to 0f365e4 Compare November 19, 2025 12:06
@graphite-app graphite-app bot changed the base branch from graphite-base/7136 to develop November 19, 2025 12:06
@CDRussell CDRussell force-pushed the feature/craig/add_sync_promo_to_bookmark_added_dialog branch 3 times, most recently from 6f6b0cb to 2c50b92 Compare November 19, 2025 15:56
@CDRussell CDRussell marked this pull request as ready for review November 19, 2025 17:03
@CDRussell CDRussell force-pushed the feature/craig/add_sync_promo_to_bookmark_added_dialog branch from 2c50b92 to 343bf34 Compare November 19, 2025 17:13
@CDRussell CDRussell force-pushed the feature/craig/add_sync_promo_to_bookmark_added_dialog branch from 343bf34 to 9279f1a Compare November 19, 2025 17:22
@CDRussell CDRussell force-pushed the feature/craig/add_sync_promo_to_bookmark_added_dialog branch from 5148142 to d94ad28 Compare November 20, 2025 10:39
@CDRussell CDRussell merged commit 56b3bc7 into develop Nov 20, 2025
7 checks passed
@CDRussell CDRussell deleted the feature/craig/add_sync_promo_to_bookmark_added_dialog branch November 20, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants