This repository was archived by the owner on Feb 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 440
[Draft] shared web tests #3933
Draft
jonathanKingston
wants to merge
28
commits into
main
Choose a base branch
from
jkt/shared-web-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Draft] shared web tests #3933
Changes from 14 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
97c7254
Big ol backup
jonathanKingston 8b76ca3
Backup of existing work
jonathanKingston 39b2b03
Merge remote-tracking branch 'origin/main' into jkt/shared-web-tests
jonathanKingston 7803231
Use launch args and logging
jonathanKingston 7c02f28
Merge remote-tracking branch 'origin/main' into jkt/shared-web-tests
jonathanKingston f8ec2b4
Remove maestro specific changes
jonathanKingston 6549f46
Add github workflow
jonathanKingston 9051f24
Remove maestro specific setup
jonathanKingston 8467795
Reorder action
jonathanKingston f3ab4cc
Move changes to extensions
jonathanKingston 3c11508
Separate out automation steps into their own methods
jonathanKingston 7043bf3
Merge remote-tracking branch 'origin/main' into jkt/shared-web-tests
jonathanKingston 463ab99
Remove debug if statements
jonathanKingston d46f947
Remove force try in automation server
jonathanKingston 8f82b7d
Rename startAutomationServer to startAutomationServerIfNeeded
jonathanKingston f05c8d7
Remove making controller public
jonathanKingston 93ac4df
Make AutomationServer final
jonathanKingston 7b00a95
Remove stray commented out global connection handler for Automation
jonathanKingston cbcd86f
Move currentURL method into direct access within the server
jonathanKingston e76cd77
Reduce nesting in AutomationServer
jonathanKingston 4313f26
Return early by using guards for error states
jonathanKingston 2fd77ec
Switch object identifiers to use tabModel.uid
jonathanKingston 8f4a97f
Merge remote-tracking branch 'origin/main' into jkt/shared-web-tests
jonathanKingston 784ddb5
Merge remote-tracking branch 'origin/main' into jkt/shared-web-tests
jonathanKingston 6d71981
Automation fixes
jonathanKingston ef7df0c
Get mainViewController in automation server
jonathanKingston 2b558e9
Simplify configuration of tests
jonathanKingston af83c26
Move testing steps to npm
jonathanKingston File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| name: iOS - PR Checks | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main, "release/**", 'jkt/shared-web-tests' ] | ||
| pull_request: | ||
| workflow_call: | ||
| inputs: | ||
| branch: | ||
| description: "Branch name" | ||
| required: false | ||
| type: string | ||
| skip-release: | ||
| description: "Skip release build" | ||
| required: false | ||
| default: false | ||
| type: boolean | ||
| secrets: | ||
| APPLE_API_KEY_BASE64: | ||
| required: true | ||
| APPLE_API_KEY_ID: | ||
| required: true | ||
| APPLE_API_KEY_ISSUER: | ||
| required: true | ||
| ASANA_ACCESS_TOKEN: | ||
| required: true | ||
| MATCH_PASSWORD: | ||
| required: true | ||
| SSH_PRIVATE_KEY_FASTLANE_MATCH: | ||
| required: true | ||
|
|
||
| jobs: | ||
| shared-web-tests: | ||
| name: Shared web tests | ||
|
|
||
| runs-on: macos-15 | ||
| timeout-minutes: 20 | ||
| steps: | ||
| - name: Check out the code | ||
| if: github.event_name == 'pull_request' || github.event_name == 'push' | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive | ||
|
|
||
| - name: Select Xcode | ||
| run: sudo xcode-select -s /Applications/Xcode_$(<.xcode-version).app/Contents/Developer | ||
|
|
||
| - name: Checkout shared web tests | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: duckduckgo/shared-web-tests | ||
| path: shared-web-tests | ||
| ref: jkt/webdriver | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Build and Test | ||
| run: | | ||
| cd ../shared-web-tests | ||
| npm run build | ||
| cd web-driver | ||
| cargo build | ||
|
|
||
| - name: Build iOS | ||
| run: | | ||
| source .maestro/common.sh | ||
| project_root=$(pwd) | ||
| build_app | ||
|
|
||
| - name: Add CA key | ||
| run: | | ||
| xcrun simctl keychain booted add-root-cert ../shared-web-tests/web-platform-tests/build/tools/certs/cacert.pem | ||
|
|
||
| - name: Run tests | ||
| run: | | ||
| cd ../build | ||
| ./wpt run --product duckduckgo --binary ../webdriver/target/debug/ddgdriver --log-mach - --log-mach-level info duckduckgo | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.