Skip to content

Conversation

@MartijnBl
Copy link

The API endpoint expects limit to be a string.

Cast the limit to a sting before sending off the API request

Description

Cast the limit to a sting before sending off the API request

Motivation and Context

A user of the api lib would reasonably expect a limit to be an int, not a string. Arguable the endpoint will probably cast this back to an int straight away :)

How Has This Been Tested?

Locally tested

Types of Changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

The API endpoint expects limit to be a string.
@MartijnBl MartijnBl changed the title Cast limit in to a string get_authentication_logcast limit in Cast limit in get_authentication_log to a string Feb 19, 2025
@AaronAtDuo
Copy link
Contributor

@MartijnBl I apologize for taking so long to look at this PR. It looks good to me. However, the time limit for CI has passed, I need you to re-trigger it by updating the PR. I've found the easiest way to be git commit --amend --no-edit and then git push --force the branch again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants