Skip to content

chore: Remove use of legacy restore, which is now deprecated #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronAtDuo merged 2 commits into from
Mar 25, 2025
Merged

chore: Remove use of legacy restore, which is now deprecated #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
655caa7
chore: Remove use of legacy restore, which is now deprecated
robbie-duo Mar 24, 2025
a495d14
chore: Changes requested by amcconnell
robbie-duo Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions duo_client/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2040,8 +2040,8 @@ def update_settings(self,
helpdesk_bypass_expiration - <int:minutes>|0
helpdesk_message - <str:message|None>
helpdesk_can_send_enroll_email - True|False|None
reactivation_url - <str:url>|None
reactivation_integration_key - <str:url>|None
reactivation_url - Deprecated; ignored if specified.
reactivation_integration_key - Deprecated; ignored if specified.
security_checkup_enabled - True|False|None
user_managers_can_put_users_in_bypass - True|False|None
email_activity_notification_enabled = True|False|None
Expand Down Expand Up @@ -2113,10 +2113,6 @@ def update_settings(self,
if helpdesk_can_send_enroll_email is not None:
params['helpdesk_can_send_enroll_email'] = ('1' if
helpdesk_can_send_enroll_email else '0')
if reactivation_url is not None:
params['reactivation_url'] = reactivation_url
if reactivation_integration_key is not None:
params['reactivation_integration_key'] = reactivation_integration_key
if security_checkup_enabled is not None:
params['security_checkup_enabled'] = ('1' if
security_checkup_enabled else '0')
Expand Down
4 changes: 0 additions & 4 deletions tests/admin/test_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ def test_update_settings(self):
helpdesk_bypass_expiration=60,
helpdesk_message="test_message",
helpdesk_can_send_enroll_email=True,
reactivation_url="https://www.example.com",
reactivation_integration_key='DINTEGRATIONKEYTEST0',
security_checkup_enabled=True,
user_managers_can_put_users_in_bypass=False,
email_activity_notification_enabled=True,
Expand Down Expand Up @@ -79,8 +77,6 @@ def test_update_settings(self):
'helpdesk_bypass_expiration': '60',
'helpdesk_message': 'test_message',
'helpdesk_can_send_enroll_email': '1',
'reactivation_url': 'https://www.example.com',
'reactivation_integration_key': 'DINTEGRATIONKEYTEST0',
'security_checkup_enabled': '1',
'user_managers_can_put_users_in_bypass': '0',
'email_activity_notification_enabled': '1',
Expand Down