Enable setting ipaddr param in preauth and auth #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronAtDuo
approved these changes
Jun 18, 2025
Also introduces argparse to organize args better.
brettdh
force-pushed
the
argparse-and-ipaddr
branch
from
9ab310c to
80754cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In addition to the ipaddr param, this also introduces argparse to organize args better.
Motivation and Context
I wanted to test the preauth and auth APIs with the
ipaddrfield specified.How Has This Been Tested?
Ran the example client, pointed at a test Duo instance. Saw ipaddr populated in authlogs.
Types of Changes