Replace the certs with the public key hashes since that's the only fo… #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmat Java accepts for pinning
jeffreyparker
approved these changes
May 1, 2025
Contributor
jeffreyparker
left a comment
jeffreyparker
left a comment
There was a problem hiding this comment.
Confirmed hashes all match expected values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rmat Java accepts for pinning
Description
Java pinning relies on the public key hashes, not the full cert. Replaces the certs with the hashes.
Fixes #47
Motivation and Context
Get cert pinning working again
How Has This Been Tested?
Ran a full user auth through the example
Types of Changes