Skip to content

Added ping time-keeping and number of fails #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mylogon341 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added ping time-keeping and number of fails #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12ca0e9
added ping time keeping and number of fails
lukesadlerAB May 11, 2017
2dcbc0c
Merge commit '03905f97eb266cba1522ad9fdfe46a8c176b4a3f'
mylogon341 Aug 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions RealReachability/Ping/PingHelper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ extern NSString *const kPingResultNotification;
// Ping timeout. Default is 2 seconds
@property (nonatomic, assign) NSTimeInterval timeout;

@property (readonly) NSTimeInterval previousSuccessDuration;
@property (readonly) int numberOfFailedPings;

+ (instancetype)sharedInstance;

/**
Expand Down
15 changes: 15 additions & 0 deletions RealReachability/Ping/PingHelper.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ @interface PingHelper() <PingFoundationDelegate>
@property (nonatomic, strong) NSMutableArray *completionBlocks;
@property(nonatomic, strong) PingFoundation *pingFoundation;
@property (nonatomic, assign) BOOL isPinging;
@property (nonatomic) NSDate *pingStartTime;

@end

Expand Down Expand Up @@ -107,6 +108,7 @@ - (void)clearPingFoundation
- (void)startPing
{
//NSLog(@"startPing");
_pingStartTime = [NSDate date];
[self clearPingFoundation];

self.isPinging = YES;
Expand Down Expand Up @@ -135,6 +137,15 @@ - (void)setHost:(NSString *)host

- (void)endWithFlag:(BOOL)isSuccess
{
if (isSuccess) {

NSTimeInterval duration = [_pingStartTime timeIntervalSinceNow];
_previousSuccessDuration = fabs(duration*100);

}else{
_numberOfFailedPings ++;
}

// TODO(optimization):
//somewhere around here we should introduce a double check after 3 seconds on another host,
// if maybe not truely failed.
Expand Down Expand Up @@ -188,6 +199,10 @@ - (void)pingFoundation:(PingFoundation *)pinger didFailToSendPacket:(NSData *)pa
- (void)pingFoundation:(PingFoundation *)pinger didReceivePingResponsePacket:(NSData *)packet sequenceNumber:(uint16_t)sequenceNumber
{
//NSLog(@"didReceivePingResponsePacket, sequenceNumber = %@", @(sequenceNumber));

NSTimeInterval duration = [_pingStartTime timeIntervalSinceNow];
_previousSuccessDuration = duration/1000;

[self endWithFlag:YES];
}

Expand Down