Skip to content

refactor: replace HasPrefix+TrimPrefix with CutPrefix #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: replace HasPrefix+TrimPrefix with CutPrefix #1357

wants to merge 1 commit into from

Conversation

knowmost
Copy link

@knowmost knowmost commented May 22, 2025 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

Optimize code using a more modern writing style. Official support from Go, for more details visit https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize.

For Author:

  • Targeted PR against correct branch
  • Included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case PR targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@knowmost
refactor: replace HasPrefix+TrimPrefix with CutPrefix
b15bce4 
Signed-off-by: knowmost <knowmost@outlook.com>
@knowmost knowmost requested a review from a team as a code owner May 22, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemijspavlovs artemijspavlovs artemijspavlovs approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knowmost @artemijspavlovs