Skip to content

fix: scan no free slots #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KeKe-Li wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: scan no free slots #1517

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1c6a34
fix: scan no free slots
KeKe-Li Nov 20, 2025
31b9398
Merge branch 'main' into fix-free-slots
KeKe-Li Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/orchestrator/internal/sandbox/nbd/pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,14 +227,23 @@
// Get a free device slot.
func (d *DevicePool) getFreeDeviceSlot() (*DeviceSlot, error) {
start := uint32(0)
wrapped := false

for {
slot, cleanup, ok := d.getMaybeEmptySlot(start)

if !ok {
cleanup()

return nil, NoFreeSlotsError{}
// Already wrapped around once, no free slots in the entire range
if wrapped {
return nil, NoFreeSlotsError{}
}

// Reached the end for the first time, wrap around and scan from the beginning
wrapped = true
start = 0
continue

Check failure on line 246 in packages/orchestrator/internal/sandbox/nbd/pool.go

View workflow job for this annotation

GitHub Actions / lint / golangci-lint (/home/runner/work/infra/infra/packages/orchestrator) 

continue with no blank line before (nlreturn)
}

free, err := d.isDeviceFree(slot)
Expand Down
Loading