Prefer CUDA over DirectML when both are installed #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
torchruntime.utils.get_installed_torch_platform()currently probes DirectML first. On Windows, users can have both:torch-directmlinstalled, andtorchbuild wheretorch.cuda.is_available() == True(e.g. after switching to ROCm/TheRock or CUDA wheels but leavingtorch-directmlinstalled)In that scenario, torchruntime reports the installed backend as
directmleven though CUDA/ROCm is available. This can lead to incorrect device selection and confusing logs (see runew0lf/RuinedFooocus#285).Fix
Prefer native Torch backends before DirectML:
torch.cuda(andtorch.xpu) firstTests (TDD)
Added
tests/test_torch_device_utils.pycovering:cudadirectmlNotes
This does not change the recommended platform returned by
platform_detection.get_torch_platform()for AMD on Windows (stilldirectml). It only fixes detection of what is already installed/available.