Ryu #58
Ryu #58
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds two new utility functions (removeDir and renameDir) to the utils module and updates multiple service configurations to use Easypanel's PRIMARY_DOMAIN variable. The changes also include updates to various service versions and configuration improvements.
- Added
removeDirandrenameDirutility functions for directory operations - Updated service configurations to use
$(PRIMARY_DOMAIN)instead of hardcoded localhost values - Migrated from shell-based update scripts to JavaScript-based updates for consistency
Reviewed Changes
Copilot reviewed 84 out of 90 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| utils.js | Added removeDir and renameDir utility functions for directory management |
| twenty/update.sh | Removed shell-based update script |
| twenty/update.js | Removed old update logic entirely |
| plane/update.js | Updated to use new directory utilities and configure domain variables |
| plane/setup.sh | Updated fallback URLs and curl flags for better reliability |
| plane/code/.env.example | Updated default values to use $(PRIMARY_DOMAIN) |
| plane/README.md | Added comprehensive documentation for the update process |
| supabase/update.js | Added domain configuration using $(PRIMARY_DOMAIN) |
| supabase/code/volumes/logs/vector.yml | Updated authentication to use headers instead of query parameters |
| supabase/code/docker-compose.yml | Updated service versions and environment variables |
| supabase/code/.env.example | Added new pooler configuration and updated authentication variables |
| dify/update.js | Added domain and secret key configuration |
| dify/code/* | Updated service versions and added new configuration options |
| appwrite/update.sh | Removed shell-based update script |
| appwrite/update.js | Added domain configuration using $(PRIMARY_DOMAIN) |
| appwrite/code/docker-compose.yml | Updated service versions and added new volumes/features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| async function removeDir(path) { | ||
| console.log(`Removing directory ${path}`); | ||
|
|
||
| await execa("rm", ["-rf", path]); | ||
| } |
There was a problem hiding this comment.
The removeDir function uses rm -rf without any path validation. This could be dangerous if called with malicious input (e.g., /, ~, or important system directories). Consider adding input validation to ensure the path is within expected directories or add safety checks before deletion.
| async function renameDir(src, dest) { | ||
| console.log(`Renaming directory ${src} to ${dest}`); | ||
|
|
||
| await execa("mv", [src, dest]); | ||
| } |
There was a problem hiding this comment.
The function lacks error handling. If the source directory doesn't exist or the destination already exists, the function will fail silently or throw an unclear error. Consider adding existence checks or wrapping in try-catch with descriptive error messages.
3 participants
No description provided.