Implement inferior in its own terminal on Linux #252
+135
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using DAP's runInTerminal this PR adds the ability to use that new terminal for the inferior's I/O. The basic idea of the inferior terminal on Linux is: - adapter requests client (aka vscode) to create a terminal (using runInTerminal) - in that terminal we run a small script that "returns" the tty name to the adapter (using an atomically created file with the output of tty command) - then the script waits until the adapter is complete by monitoring the PID of the adapter's node process The script run in the terminal won't auto-stop when running the adapter in server mode (typically should only be used for development of the adapter) Part of eclipse-cdt-cloud#161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using DAP's runInTerminal this PR adds the ability to use that new terminal for the inferior's I/O.
This can be enabled by adding
"inferiorTerminal": "integrated"or"inferiorTerminal": "external"or"inferiorTerminal": "auto"to the launch.json.The basic idea of the inferior terminal on Linux is:
The script run in the terminal won't auto-stop when running the adapter in server mode (typically should only be used for development of the adapter)
Part of #161
TODO for this issue: