Skip to content
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ The Trace Server Protocol is a protocol designed to allow frontend visualizers t

* Keep things as imutable as possible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

immutable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as possible.

* A trace can be queried for any UI elements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any UI element.

** UI elements can be but should not be limited to charts, graphs, trees and more.
** Filtering on the server side may produce additional UI elements.
** The data type is delivered to the client so the client can remain as lightweight as possible.
* UI elements can be but should not be limited to charts, graphs, trees and more.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdownlint has issues with this reformatted line and the few ones below (8 and 9).

* Filtering on the server side may produce additional UI elements.
* The data type is delivered to the client so the client can remain as lightweight as possible.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second commit should be squashed into the first/base one, here in this specific case.


The initial design is base on the Eclipse Trace Compass backend and the theia-trace-extension frontend, however this protocol is agnostic and all changes will be considered and suggestions are welcomed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is based on


Expand Down