update guava and gson #882
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
|
I assume this update isn't needed for 2025-03? |
|
Depends on how many gsons we want to end up in simrel |
jonahgraham
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
We don't have dups in SimRel for these at the moment. This change LGTM, but it only affects what we build and publish, it doesn't change our dependencies so won't affect what is in SimRel.
When SimRel / Maven Central has new versions of guava and gson than in our versions gradle file, we can adjust the ranges.
So, if I am not missing anything, I won't do a new release for this change.
|
lets see what m3 will show. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.