Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Dec 23, 2025

Migrated the following tests from JUnit 4 (CloseTestWindowsRule) to JUnit 5 (CloseTestWindowsExtension):

  • Bug264804Test.java
  • Bug231304Test.java
  • ShowViewMenuTest.java
  • Bug410426Test.java
  • MenuVisibilityTest.java

Replaced @rule CloseTestWindowsRule with @ExtendWith(CloseTestWindowsExtension.class) and updated JUnit annotations.

Migrated the following tests from JUnit 4 (CloseTestWindowsRule) to JUnit 5 (CloseTestWindowsExtension):
- Bug264804Test.java
- Bug231304Test.java
- ShowViewMenuTest.java
- Bug410426Test.java
- MenuVisibilityTest.java

Replaced @rule CloseTestWindowsRule with @ExtendWith(CloseTestWindowsExtension.class) and updated JUnit annotations.
@github-actions
Copy link
Contributor

Test Results

 3 015 files  ±0   3 015 suites  ±0   2h 13m 0s ⏱️ +9s
 8 258 tests ±0   8 010 ✅ ±0  248 💤 ±0  0 ❌ ±0 
23 598 runs  ±0  22 807 ✅ ±0  791 💤 ±0  0 ❌ ±0 

Results for commit bf2a112. ± Comparison against base commit 6d06b55.

@vogella vogella merged commit 447e516 into eclipse-platform:master Dec 23, 2025
18 checks passed
@vogella vogella deleted the migrate-closetestwindowsrule-junit5 branch December 23, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant