Mark test methods for deprecated API as deprecated #2396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 1 956 files 1 956 suites 1h 28m 55s ⏱️ Results for commit d4846a5. ♻️ This comment has been updated with latest results. |
HeikoKlare
force-pushed
the
resourcetests-deprecated-methods
branch
from
6236f47 to
38cd04e
Compare
For methods testing deprecated API, the according warnings have been suppressed. However, it seems more reasonable to mark those methods as deprecated themselves. This adapts the annotations of those methods and applies deprecations to further test methods that explicitly test deprecated API.
HeikoKlare
force-pushed
the
resourcetests-deprecated-methods
branch
from
38cd04e to
d4846a5
Compare
Contributor
Author
|
ftr: this fixed 27 warnings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For methods testing deprecated API, the according warnings have been suppressed. However, it seems more reasonable to mark those methods as deprecated themselves.
This adapts the annotations of those methods and applies deprecations to further test methods that explicitly test deprecated API.